From cb9da34ec5bb8c7b3bb0ba58f4583a28efeab427 Mon Sep 17 00:00:00 2001 From: zichun Date: Tue, 26 May 2026 10:42:31 +0800 Subject: [PATCH] refactor: remove 17 superseded coding/crosscut skills + hooks + old reviewers --- agents/fe-code-reviewer.md | 69 --------------------------------------------------------------------- agents/superpower-code-reviewer.md | 48 ------------------------------------------------ hooks/hooks.json | 12 ------------ hooks/scripts/log-cross-module.sh | 89 ----------------------------------------------------------------------------------------- skills/coding/fe-feature-brainstorm/SKILL.md | 74 -------------------------------------------------------------------------- skills/coding/fe-feature-brainstorm/templates/fe-feature-spec-template.md | 55 ------------------------------------------------------- skills/coding/fe-feature-plan/SKILL.md | 142 ---------------------------------------------------------------------------------------------------------------------------------------------- skills/coding/fe-feature-plan/templates/fe-feature-plan-template.md | 47 ----------------------------------------------- skills/coding/fe-feature-review/SKILL.md | 40 ---------------------------------------- skills/coding/fe-feature-review/templates/commit-message-template.md | 1 - skills/coding/fe-feature-review/templates/fe-feature-review-template.md | 37 ------------------------------------- skills/coding/fe-feature-tdd/SKILL.md | 65 ----------------------------------------------------------------- skills/coding/fe-feature-tdd/templates/commit-message-template.md | 1 - skills/coding/fe-feature-verify/SKILL.md | 61 ------------------------------------------------------------- skills/coding/fe-feature-verify/templates/fe-feature-verify-evidence-template.md | 33 --------------------------------- skills/coding/feature-brainstorm/SKILL.md | 65 ----------------------------------------------------------------- skills/coding/feature-brainstorm/templates/feature-spec-template.md | 31 ------------------------------- skills/coding/feature-plan/SKILL.md | 143 ----------------------------------------------------------------------------------------------------------------------------------------------- skills/coding/feature-plan/templates/feature-plan-template.md | 28 ---------------------------- skills/coding/feature-review/SKILL.md | 37 ------------------------------------- skills/coding/feature-review/templates/feature-review-template.md | 24 ------------------------ skills/coding/feature-tdd/SKILL.md | 42 ------------------------------------------ skills/coding/feature-tdd/templates/commit-message-template.md | 1 - skills/coding/feature-verify/SKILL.md | 41 ----------------------------------------- skills/coding/feature-verify/templates/feature-verify-evidence-template.md | 16 ---------------- skills/coding/frontend-start/SKILL.md | 66 ------------------------------------------------------------------ skills/coding/frontend-start/templates/frontend-start-banner-template.md | 9 --------- skills/coding/milestone-tag/SKILL.md | 99 --------------------------------------------------------------------------------------------------- skills/coding/module-report/SKILL.md | 70 ---------------------------------------------------------------------- skills/coding/module-report/templates/module-report-template.md | 68 -------------------------------------------------------------------- skills/coding/module-start/SKILL.md | 72 ------------------------------------------------------------------------ skills/coding/module-start/templates/module-start-banner-template.md | 8 -------- skills/coding/test-gate/SKILL.md | 76 ---------------------------------------------------------------------------- skills/coding/test-gate/templates/test-gate-result-template.md | 16 ---------------- skills/crosscut/coding-start/SKILL.md | 59 ----------------------------------------------------------- skills/crosscut/coding-start/banners/flow-overview.txt | 66 ------------------------------------------------------------------ skills/crosscut/cross-module-log/SKILL.md | 31 ------------------------------- skills/crosscut/cross-module-log/templates/cross-module-log-row-template.md | 1 - skills/crosscut/cross-module-log/templates/cross-module-log-template.md | 8 -------- skills/crosscut/interrupt-check/SKILL.md | 39 --------------------------------------- skills/crosscut/interrupt-check/templates/interrupt-block-template.md | 8 -------- 41 files changed, 0 insertions(+), 1898 deletions(-) delete mode 100644 agents/fe-code-reviewer.md delete mode 100644 agents/superpower-code-reviewer.md delete mode 100644 hooks/hooks.json delete mode 100755 hooks/scripts/log-cross-module.sh delete mode 100644 skills/coding/fe-feature-brainstorm/SKILL.md delete mode 100644 skills/coding/fe-feature-brainstorm/templates/fe-feature-spec-template.md delete mode 100644 skills/coding/fe-feature-plan/SKILL.md delete mode 100644 skills/coding/fe-feature-plan/templates/fe-feature-plan-template.md delete mode 100644 skills/coding/fe-feature-review/SKILL.md delete mode 100644 skills/coding/fe-feature-review/templates/commit-message-template.md delete mode 100644 skills/coding/fe-feature-review/templates/fe-feature-review-template.md delete mode 100644 skills/coding/fe-feature-tdd/SKILL.md delete mode 100644 skills/coding/fe-feature-tdd/templates/commit-message-template.md delete mode 100644 skills/coding/fe-feature-verify/SKILL.md delete mode 100644 skills/coding/fe-feature-verify/templates/fe-feature-verify-evidence-template.md delete mode 100644 skills/coding/feature-brainstorm/SKILL.md delete mode 100644 skills/coding/feature-brainstorm/templates/feature-spec-template.md delete mode 100644 skills/coding/feature-plan/SKILL.md delete mode 100644 skills/coding/feature-plan/templates/feature-plan-template.md delete mode 100644 skills/coding/feature-review/SKILL.md delete mode 100644 skills/coding/feature-review/templates/feature-review-template.md delete mode 100644 skills/coding/feature-tdd/SKILL.md delete mode 100644 skills/coding/feature-tdd/templates/commit-message-template.md delete mode 100644 skills/coding/feature-verify/SKILL.md delete mode 100644 skills/coding/feature-verify/templates/feature-verify-evidence-template.md delete mode 100644 skills/coding/frontend-start/SKILL.md delete mode 100644 skills/coding/frontend-start/templates/frontend-start-banner-template.md delete mode 100644 skills/coding/milestone-tag/SKILL.md delete mode 100644 skills/coding/module-report/SKILL.md delete mode 100644 skills/coding/module-report/templates/module-report-template.md delete mode 100644 skills/coding/module-start/SKILL.md delete mode 100644 skills/coding/module-start/templates/module-start-banner-template.md delete mode 100644 skills/coding/test-gate/SKILL.md delete mode 100644 skills/coding/test-gate/templates/test-gate-result-template.md delete mode 100644 skills/crosscut/coding-start/SKILL.md delete mode 100644 skills/crosscut/coding-start/banners/flow-overview.txt delete mode 100644 skills/crosscut/cross-module-log/SKILL.md delete mode 100644 skills/crosscut/cross-module-log/templates/cross-module-log-row-template.md delete mode 100644 skills/crosscut/cross-module-log/templates/cross-module-log-template.md delete mode 100644 skills/crosscut/interrupt-check/SKILL.md delete mode 100644 skills/crosscut/interrupt-check/templates/interrupt-block-template.md diff --git a/agents/fe-code-reviewer.md b/agents/fe-code-reviewer.md deleted file mode 100644 index 1747590..0000000 --- a/agents/fe-code-reviewer.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -name: fe-code-reviewer -description: | - Use this agent when fe-feature-review delegates a frontend code review for a single FE-NN business feature (which may span multiple prototype HTML files / regions). Specializes in React/Vue components, styling, accessibility, prototype fidelity, and Design Tokens. Does NOT review SQL/migration/controller/service — those are the backend reviewer's domain. -model: inherit ---- - -You are a Senior Frontend Code Reviewer with deep expertise in component architecture, accessibility, design systems, and visual fidelity to design mockups. Your role is to review frontend code changes for a single FE-NN business feature (which may span multiple prototype HTML files or regions) against its associated prototypes, specification, and the project's design tokens. - -**Strict scope rules**: - -- Review ONLY frontend code (under `frontend/` or the project's frontend root per `docs/09-项目目录结构.md`). -- Do NOT propose SQL, migration, controller, service, repository, transaction, or DTO suggestions. If the diff contains backend files, flag this as a path violation and return `request-changes` with a single must-fix entry pointing the reviewee back to `feature-tdd` (backend phase). -- Do NOT recommend backend architectural changes; the backend phase is already merged. - -When reviewing, you will evaluate the following 7 dimensions in order. For each dimension, classify findings as Critical (must fix) / Important (should fix) / Suggestions (nice to have). - -## 1. Prototype 一致性 - -- Compare the rendered DOM structure (inferred from JSX/template) against the FE's `associated_prototypes` (listed in the spec header). One FE may span multiple prototype files or specific regions (anchored like `prototype/dashboard.html#metrics-section`). -- For each associated prototype / region, check: top navigation placement, grid columns, primary action button position, key region layout (header / filters / table / pagination). -- Allowed: implementation differences (class naming, component library syntax, framework idioms). -- Not allowed: structural deviation (e.g., moving the primary action from top-right to bottom-center, dropping a filter region the prototype shows). - -## 2. Design Tokens - -- All color values MUST use `var(--color-*)` per `docs/06 § 二`. -- Hard-coded hex / rgb values → `request-changes` with file:line. -- New tokens introduced in code without registration in `docs/06 § 二` and `tokens.css` → `request-changes`. - -## 3. 无障碍 (Accessibility) - -- Form controls have `