From 3a625ce9f68d5dc3f605f4429be0697fdf73f3db Mon Sep 17 00:00:00 2001
From: zichun <zhuzichunhogan@gmail.com>
Date: Thu, 30 Apr 2026 14:58:38 +0800
Subject: [PATCH] refactor(usr): remove stub fallback in services REQ-USR-004

---
 backend/src/main/java/com/xly/erp/module/mod/service/impl/ModuleServiceImpl.java | 6 ++----
 backend/src/main/java/com/xly/erp/module/usr/service/impl/UserServiceImpl.java   | 6 ++----
 backend/src/test/java/com/xly/erp/module/mod/service/ModuleServiceImplTest.java  | 4 ++--
 backend/src/test/java/com/xly/erp/module/usr/service/UserServiceImplTest.java    | 2 +-
 4 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/backend/src/main/java/com/xly/erp/module/mod/service/impl/ModuleServiceImpl.java b/backend/src/main/java/com/xly/erp/module/mod/service/impl/ModuleServiceImpl.java
index b272bb2..d4113b0 100644
--- a/backend/src/main/java/com/xly/erp/module/mod/service/impl/ModuleServiceImpl.java
+++ b/backend/src/main/java/com/xly/erp/module/mod/service/impl/ModuleServiceImpl.java
@@ -61,8 +61,7 @@ public class ModuleServiceImpl implements ModuleService {
         m.setSModuleNameZh(dto.getSModuleNameZh());
         m.setIParentId(dto.getIParentId());
         m.setISortOrder(dto.getISortOrder() != null ? dto.getISortOrder() : 0);
-        String authedUserNo = SecurityContextHelper.currentUserNo();
-        m.setSCreatedBy(authedUserNo != null ? authedUserNo : stub.getStubUserNo());
+        m.setSCreatedBy(SecurityContextHelper.currentUserNo());
         m.setBDeleted(false);
 
         try {
@@ -112,8 +111,7 @@ public class ModuleServiceImpl implements ModuleService {
         entity.setIIncrement(id);
         entity.setBDeleted(true);
         entity.setTDeletedDate(LocalDateTime.now());
-        String authedUserNo = SecurityContextHelper.currentUserNo();
-        entity.setSDeletedBy(authedUserNo != null ? authedUserNo : stub.getStubUserNo());
+        entity.setSDeletedBy(SecurityContextHelper.currentUserNo());
         moduleMapper.updateById(entity);
     }
 
diff --git a/backend/src/main/java/com/xly/erp/module/usr/service/impl/UserServiceImpl.java b/backend/src/main/java/com/xly/erp/module/usr/service/impl/UserServiceImpl.java
index b672a75..0c7df8a 100644
--- a/backend/src/main/java/com/xly/erp/module/usr/service/impl/UserServiceImpl.java
+++ b/backend/src/main/java/com/xly/erp/module/usr/service/impl/UserServiceImpl.java
@@ -124,8 +124,7 @@ public class UserServiceImpl implements UserService {
         entity.setSLanguage(dto.getSLanguage());
         entity.setBCanModifyDocs(dto.getBCanModifyDocs() != null ? dto.getBCanModifyDocs() : false);
         entity.setSPasswordHash(passwordEncoder.encode(DEFAULT_PASSWORD));
-        String authedUserNo = SecurityContextHelper.currentUserNo();
-        String createdBy = authedUserNo != null ? authedUserNo : stub.getStubUserNo();
+        String createdBy = SecurityContextHelper.currentUserNo();
         entity.setSCreatedBy(createdBy);
         entity.setBDeleted(false);
 
@@ -193,8 +192,7 @@ public class UserServiceImpl implements UserService {
 
         userPermissionMapper.deleteByUserId(id);
         if (ids != null && !ids.isEmpty()) {
-            String authedUserNo = SecurityContextHelper.currentUserNo();
-            String createdBy = authedUserNo != null ? authedUserNo : stub.getStubUserNo();
+            String createdBy = SecurityContextHelper.currentUserNo();
             LocalDateTime now = LocalDateTime.now();
             for (Integer cid : ids) {
                 UserPermission rel = new UserPermission();
diff --git a/backend/src/test/java/com/xly/erp/module/mod/service/ModuleServiceImplTest.java b/backend/src/test/java/com/xly/erp/module/mod/service/ModuleServiceImplTest.java
index 4e49e77..ec38f20 100644
--- a/backend/src/test/java/com/xly/erp/module/mod/service/ModuleServiceImplTest.java
+++ b/backend/src/test/java/com/xly/erp/module/mod/service/ModuleServiceImplTest.java
@@ -70,7 +70,7 @@ class ModuleServiceImplTest {
         assertThat(saved.getSBrandsId()).isEqualTo("XLY");
         assertThat(saved.getSSubsidiaryId()).isEqualTo("XLY");
         assertThat(saved.getTCreateDate()).isNotNull();
-        assertThat(saved.getSCreatedBy()).isEqualTo("STUB_ADMIN");
+        assertThat(saved.getSCreatedBy()).isNull();
         assertThat(saved.getBDeleted()).isFalse();
         assertThat(saved.getBShowPermission()).isFalse();
         assertThat(saved.getISortOrder()).isZero();
@@ -254,7 +254,7 @@ class ModuleServiceImplTest {
         assertThat(passed.getIIncrement()).isEqualTo(10);
         assertThat(passed.getBDeleted()).isTrue();
         assertThat(passed.getTDeletedDate()).isNotNull();
-        assertThat(passed.getSDeletedBy()).isEqualTo("STUB_ADMIN");
+        assertThat(passed.getSDeletedBy()).isNull();
         assertThat(passed.getSProcedureName()).isNull();
         assertThat(passed.getSCreatedBy()).isNull();
         assertThat(passed.getSBrandsId()).isNull();
diff --git a/backend/src/test/java/com/xly/erp/module/usr/service/UserServiceImplTest.java b/backend/src/test/java/com/xly/erp/module/usr/service/UserServiceImplTest.java
index 8d54395..799002f 100644
--- a/backend/src/test/java/com/xly/erp/module/usr/service/UserServiceImplTest.java
+++ b/backend/src/test/java/com/xly/erp/module/usr/service/UserServiceImplTest.java
@@ -100,7 +100,7 @@ class UserServiceImplTest {
         verify(userMapper).insert(userCap.capture());
         User saved = userCap.getValue();
         assertThat(saved.getSBrandsId()).isEqualTo("XLY");
-        assertThat(saved.getSCreatedBy()).isEqualTo("STUB_ADMIN");
+        assertThat(saved.getSCreatedBy()).isNull();
         assertThat(saved.getTCreateDate()).isNotNull();
         assertThat(saved.getSPasswordHash()).startsWith("$2a$");
         assertThat(saved.getBDeleted()).isFalse();
--
libgit2 0.22.2