朱子纯 / erp-workflow-plugin

Replaces the phase-level read-only behavior-gate with a per-FE acceptance dimension: each FE is approved only when the code-reviewer approves AND runtime behavior verification is green. Behavior defects (dead control / sentinel text mismatch) become fixable must-fix that drive verify->fix->re-verify, not halts.

- reviewWithFixLoop (frontend only, via if(fe)): at the approve gate, behaviorSubGate boots this FE's full stack + seeds sentinels, enumerates this FE's routes, two-tier asserts. Hard issues with a locator -> fixPrompt -> functional reverify -> next behaviorRound; soft text (i18n/literal/semantic) -> adjudicate(continue); behaviorRound bounded by BEHAVIOR_FE_MAX=3, env race by BEHAVIOR_ATTEMPT_MAX=2. Backend featureLoop branch unchanged.

- New runFrontendSkeleton stage (before featureLoop(frontend)): App shell + full lazy router + FeStub placeholders + shared nav, so the app is buildable at every mid-phase point; tdd swaps FeStub->real component per FE. Idempotent via fe-skeleton-done tag.

- BEHAVIOR_GATE_SCHEMA gains build-failed envError kind (sibling-FE-unimpl short-circuit, not a bug) + locator-not-resolvable coverage reason; deriveSpec emits a per-FE route-scope section, reviewer validates it.

- Removed phase-level runBehaviorGate + 'Behavior' phase; kept phase-level testGate (regression). REVIEW_HARD_ROUNDS 8->10.

- Safety: test-DB naming guard pushed into scripts-setup-test-db.mjs template (fail-closed unless name contains test/_dev/_local or ALLOW_NONTEST_DROP=1) + 3 tests.

- agentType stays erp-workflow:code-reviewer. v1 design doc marked SUPERSEDED; v2 design at docs/design/2026-06-02-frontend-behavior-in-review-loop.md.

Verified: wrapped syntax check SYNTAX_OK, 87/87 lib tests pass, no orphan refs, no time/random builtins, top-level return intact. Not yet run end-to-end against a real ERP project.

New 'Behavior' stage between Gate and Milestone, frontend-phase only, after testGate green and before report/milestone. Verifies every interactive control actually works and every text region shows the right content, independent of the tests the tdd agent wrote.

- BEHAVIOR_GATE_SCHEMA / behaviorGateContract() / behaviorGatePrompt() / runBehaviorGate(); reportPrompt now gates the milestone on behavior-gate evidence (frontend-phase-behavior-gate-r*.md, last attempt must be non-RED).

- Two-tier failure: interaction defects (incl. binding-garbage) flake-retry once then hard-halt via adjudicate(allowContinue:false); text issues split by source (sentinel=objective -> no continue; i18n/literal/semantic=adjudicable). Convergence loop re-runs the env + interaction hard gates after any text-layer retry so a refreshed result can't slip a green past the hard gates.

- Full-stack seeded run: test-DB name guard (deterministic halt, not adjudicated), strict 4-phase ordering (empty DB -> boot backend so Flyway builds schema -> seed -> boot frontend), auth bootstrap via storageState, router-config-driven route discovery, ephemeral .tmp/behavior-gate runner with finally teardown, type-legal per-field-unique sentinels.

- agentType uses the plugin-namespaced 'erp-workflow:code-reviewer' (a bare 'code-reviewer' is ambiguous with feature-dev:code-reviewer); README + agents/code-reviewer.md aligned (frontmatter name: stays bare).

- Design: docs/design/2026-06-02-frontend-behavior-gate.md. README + coding-start banner updated.

…n-check + projectRoot

git 就绪（默认分支/工作树干净/功能分支创建与合并）改由 coding.mjs runBranchSetup 运行时把守；
入口只校验 Plan 完成态（docs/08 §一 全勾）并取 projectRoot 绝对路径传入 Workflow。
相应收窄 allowed-tools（去掉 git status/branch/checkout 授权）。

validate-ddl now recognizes the db-init A.1 DDL form (CREATE TABLE →
CREATE INDEX → ALTER TABLE ADD FK), so schemas with out-of-body indexes/
FKs no longer report false-positive index/FK diffs. Adds a second parse
pass (mergeStandaloneIndexes / mergeStandaloneForeignKeys), string-literal
blanking so DEFAULT/COMMENT text isn't mistaken for real DDL, backtick
non-ASCII identifier support across all matchers (H3), and shared index-
column normalization (strip backtick / prefix-length / ASC|DESC) on both
docs and DDL sides. Chinese 主键/唯一 index labels map to PRIMARY/UNIQUE.

apply-ddl resolves mysql2 from the target project dir (not the plugin),
rejects 【人工填写】 credential placeholders before connecting, and exits 2
on missing config/DDL paths. setup-test-db template validates schema as an
ASCII identifier before interpolating it into DROP/CREATE. db-init gains a
B.1 toolchain precheck (mysql2 module + mysql client) before any DROP.

- db-design-gen: drop unused `AskUserQuestion` grant (the A0 convention-
  confirm step was removed; conventions are now fixed in step B). Update the
  stale README A3 row that still described the dropped AskUserQuestion flow.
- downstream-gen: drop unused `Skill` grant (terminal A step — it stops for
  /plan-start, never dispatches).
- skeleton-gen: QA banner 产出清单 referenced docs/07, which was removed
  (the skill itself states A2 no longer emits docs/06/07/09) → drop it.
- project-init: align description with body + README — dependency check is
  auto-install-then-stop, not give-instructions-and-stop.

- check 1 grep set: remove `待补` — it is used nowhere as a placeholder
  convention (real tokens are 【人工填写：…】 / TBD(...) / {{...}}), so it
  matched nothing.
- replace the inaccurate "(与 scope-lock E.1 同集合)" note: this terminal gate
  greps a superset (`{{` + `TBD` + `【人工填写`) precisely because the
  TBD(A3/A5 自动补) placeholders legitimately deferred at A1 must be resolved
  by now — explaining the value-add over E.1 instead of claiming false parity.

- docs/10 was generated once at A5 and never read back by any skill,
  workflow, or gate (the `acceptance` hits elsewhere are the per-REQ card
  field, unrelated). Removing it costs the pipeline nothing.
- delete docs-10-header-template.md; drop step E + its checkbox, banner
  entry, description mention, and reference-list entry from the skill;
  renumber old step F → E.
- drop the docs/10 checkbox from docs-08-initial-template.md.
- update README (A5 flow line, A5 table row, template-table row).

- docs-05 header: collapse the `## 全局约定` block (response-format JSON +
  auth/pagination placeholders) into a single pointer to docs/04 (the
  conventions SSoT). Also fixes a broken ref — it cited "docs/04 § 1.4
  错误码段位", but § 1.4 is 统一响应格式 and no such section exists.
- docs-02: remove the free-form `## 三、关键说明 {{notes}}` filler section
  (the skill defines no source for it).

- step B: remove the inline `node -e` mysql SELECT-1 probe (3rd copy of the
  YAML parser + a connection test C.1 setup-test-db.mjs already performs);
  keep only the cheap 5-field non-empty/placeholder credential check, fold
  the Glob existence check into Read, drop now-unused Glob from allowed-tools
- checkboxes: A.3 → `DDL ↔ docs/03 5 维一致（validate-ddl.mjs）`; drop the
  misleading "apply 后 5 维一致" item in D (apply does not change V1, nothing
  re-validates); rename the creds checkbox to "5 项非空校验通过"
- sync the A4 block in docs-08-initial-template.md (5 → 4 sub-items)
- update frontmatter description to match the new flow

…0 convention machinery

- schema 约定（iIncrement 主键 / sId 业务ID / sBrandsId+sSubsidiaryId 多租户 / tCreateDate / 匈牙利前缀）从「A0 询问 + 可配置 {{}} 占位 + docs/04 § 四」改为**固定写死**在 docs-03-header-template + docs-03-table-template
- remove A0 step（约定固定，无需向用户确认）；B 内联引用固定标准列（去掉指向尚未生成的 docs/03 的前向引用）；C.1/C.2 去掉 {{PK_CONVENTION}}/{{TENANT_COLS}}/{{COL_PREFIX_RULE}} 填充/展开
- docs/04 § 四 不再被任何环节创建或引用（schema 约定单一来源 = docs/03）

- delete docs-07-env-template.md (§一 依赖↔docs/04 §零; §二 端口↔config-vars.yaml; §四 命令↔docs/04 §零 build/lint/unit/e2e; §三 规则折入 config-vars.yaml 头)
- skeleton-gen: B.1 (gen docs/07) removed → B = just append docs/04 §一+; add 'A2 不再单独出 docs/06/07/09 — 各内容归属' note; frontmatter/checkbox/E.1-scan/参考 drop docs/07
- config-vars.yaml header: + 2 guardrails (配置值不散落; base_package 锁定后复用)
- plan-start drop 'docs/07 仅承载规则' note; docs-08 checkbox; README A2 row + template table

- docs-04 template: remove § 2.5 样式与主题 (tokens live in src/styles/tokens.css) + § 3.5 配置与安全 (config in config-vars.yaml, rules in docs/07→now config-vars header)
- styles-tokens-template.css: fix 3 stale docs/06 refs missed in the earlier docs/06 removal (greps had excluded *.css) → self-contained '色值单一来源 / SSoT'
- coding.mjs: frontend ref §一 前端架构 → §二 前端规范 (§一 is 后端); backend drop frontend §2.1 → §1.2 分层; 样式/色值 → tokens.css; remove docs/07 from value-lookup order

- delete docs-09-structure-template.md (its § 二/§ 三 dir layout duplicated docs/04 § 1.2/2.1; § 四 docs-tree was a self-referential maintenance trap; § 五 overlapped docs/04)
- skeleton-gen B.1 now generates only docs/07; B.2 captures backend/frontend dir layout into docs/04 § 1.2/2.1; frontmatter/checkbox/参考 drop docs/09
- coding.mjs (6 refs): file placement -> docs/04 § 1.2/2.1; frontend root -> frontend/ convention; cross-module path->module -> docs/08 § 二 路径: field
- CLAUDE-template rule #2 -> docs/04 § 1.2/2.1; docs-08 checkbox + README A2/template-table drop docs/09

- delete lib/merge-gitignore.mjs + merge-gitignore.test.mjs: over-engineered for a once-run greenfield step (base .gitignore usually absent; duplicate ignore patterns are harmless)
- D now uses C.1-style Read+Write: Write template if no .gitignore, else append missing lines (consistent with render.mjs removal + scope-lock direct-write)
- removes the 'pre-Write empty .gitignore' fragility (Write self-creates); skeleton-gen drops Bash(node *) from allowed-tools

尾部 6/6 reset-test-db 与下次运行的 1/x setup-test-db 重复（都 DROP+CREATE），对正确性零贡献；删除后闸门为 detect→setup→build→lint→test→e2e，重编号 1/5..5/5。

- C.1: stop generating sql/migrations/.gitkeep (A4 db-init's Write V1 creates the dir); README A2 drops 'create empty migrations dir'
- precedence rule: on color conflict, tokens.css wins over prototype (prototype = structure/layout/interaction; tokens.css = color) — encoded in skeleton-gen note, coding.mjs frontend stage, code-reviewer § Design Tokens

- skeleton-gen B.1: remove stale line claiming 根包名/命名空间 placeholder is filled at docs/09 top (docs/09 has no such placeholder; base_package lives in config-vars.yaml since A1)
- docs-05-header: 端口 占位 -> pointer to config-vars.yaml backend.http_port (was a duplicate 【人工填写】 of the same port)

- README (A0 row + prerequisites): dep check now auto-installs missing tools (was: print guide + halt, no auto-install), matching project-init SKILL
- project-init SKILL: fix typo 失败失败 -> 失败
- CLAUDE template rule #5: inline cross-module 留痕 requirement (soft-rule S2 table was removed)

- A0 SKILL: drop inline cross-platform dep-check script + OS install guides; dep check now auto-installs missing tools (was detect-only); trim 用 Edit/用 Bash 等工具名提示
- CLAUDE template: remove B 阶段流程 / 占位符约定 / 🚩 中断机制 / 🟡 软规则(S1,S2) / 硬规则#6 / 禁止项#2 等小节
- docs-01 index: drop trailing 填写说明

- delete frontend-scope-lock skill + docs/06 templates (static + module-pagelist)
- A5 downstream-gen gains prototype/ gate + FE-list derivation -> docs/08 § 三
- plan-start: drop A6 dispatch row, gate 5->4 items; coding-start A0~A6 -> A0~A5
- Design Tokens single source = src/styles/tokens.css (code-reviewer, coding.mjs)
- plugin.json skills 9->8; docs-09 tree drops 06-UI; docs-08 drops A6 section

- D-step: CC writes _module.md/REQ-*.md directly (no render.mjs/vars.json)
- req-card template restructured: input/output example tables copied verbatim, CC fills 6 {{}} scalars; E.1 validates {{}} residual only
- E.2: write all config (incl. secret placeholders) into config-vars.yaml
- E.4: no human-review stop — auto Skill(skeleton-gen) into A2

- config-vars.yaml now holds全部 config incl. secrets (database/admin_init.password/secrets), committed
- delete env-local-template; setup-test-db reads config-vars.yaml; gitignore no longer ignores .env.local
- docs-07 single-store rule; db-init/db-design-gen read config-vars.yaml database: section
- drop test_db_allowed_hosts whitelist + schema-looks-like-test guard (trust config-vars.yaml)

docs-06-static-template.md actually defines § 二 Design Tokens with
subsections 2.1 / 2.2 / 2.3. The CSS template comments still cited the
pre-renumber § 四 / § 4.1 / § 4.2, so downstream-generated tokens.css
files pointed readers to non-existent sections of docs/06.

…, single-source error-codes

…d parenthetical 参考 blocks

Visual clarity: the file tree now matches the README's phase model.
- skills/plan/   — 8 skills (plan-start entry + A0~A6)
- skills/coding/ — 1 skill (coding-start thin entry)

Slugs unchanged. /erp-workflow:<name> still resolves identically because
each SKILL.md declares its own `name:` frontmatter (verified for all 9).

Plugin loader treats the default `./skills/` scan as flat, so the nested
layout is opted into via an explicit path array in plugin.json — the only
mechanism Claude Code provides for nested skill discovery.

Changes:
- mv skills/{plan-start,project-init,scope-lock,skeleton-gen,
       db-design-gen,db-init,downstream-gen,frontend-scope-lock}
     → skills/plan/<same>/
- mv skills/coding-start → skills/coding/coding-start/
- .claude-plugin/plugin.json: skills[] now lists all 9 explicit paths
- README.md: directory tree + Skill 清单 heading updated to reflect grouping

No code touches any skill path (only README did, and only in the tree
diagram). lib tests still pass (62/62).

Independent Claude + Codex review of the working-tree diff surfaced
23 issues; all applied in-place across three domains.

workflows/coding.mjs (9):
- spec/plan/verify/review prompts now git-commit their artifacts
  (closes milestone-dirty-worktree halt risk)
- CHECKBOX_STATE_SCHEMA requires `state` + defensive guard in reviewWithFixLoop
- writeDocs08FieldPromptM scopes edits to module via line anchor
- assertSafeId guards Router output (module/REQ/FE ids)
- featureLoop captures reviewWithFixLoop's return value
- dateFromArtifactPath rejects impossible dates (9999-99-99 etc.)
- terminal HALT review-unresolved message disambiguated
- updated comment on top-level `return` (ESM vs node --check)

lib/validate-ddl.mjs + tests (10):
- extractType preserves unsigned/signed modifiers
- KEY/INDEX fallthrough no longer creates spurious 'KEY' columns
- FOREIGN KEY REFERENCES accepts schema-qualified `db.table`
- index keys normalized to name:kind:cols (UNIQUE-aware)
- FK keys include ON DELETE action (defaults to RESTRICT)
- CREATE TEMPORARY TABLE parsed
- parseForeignKeyBullet/parseIndexBullet reject prose bullets
- +10 regression tests (62 total, all pass)
- merge-gitignore.mjs docstring synced to implementation

skills/ (4):
- docs-06 template header: § 一~二 → § 一~三
- downstream-gen §A steps renumbered 1-7 (was 1,3,4,5,6,7,8)
- docs-08 initial template adds tokens.css checkbox
- coding-start drops "已在后台启动" wording (Workflow is synchronous)

- 新增 scope-lock/templates/config-vars-template.yaml：非敏感项目级配置
  （包名/端口/前端包名/初始账号）+ secrets_ref 键名引用 .env.local；
  A1 E.2 锁定。docs/07 改为只记规则/约定不记具体值。
- 连带更新 skeleton-gen / plan-start 闸门 2 / frontend-scope-lock /
  CLAUDE-template / README / docs-06·07 模板对齐新的配置分层与 docs/06 小节编号。
- lib 修复（含回归测试）：
  - apply-ddl: 抽出 resolveDbConfig，DB_SCHEMA 为契约 schema 键，缺库名 fail-closed (M1)
  - render: 用 Object.hasOwn 拒绝原型链继承键，guard process.argv[1]
  - validate-ddl: 解析 ### 索引/### 外键 bullet (C2)、剥 SQL 注释防幽灵表 (L4)、PRIMARY 归一化
- coding.mjs: Router 把全部前端 FE 聚合为单一末尾 frontend-phase 模块；
  新增 branchSetupPrompt 功能分支生命周期 (C1)；diff 区间改三点 diff；fix 后复跑 verify。

- Delete all 7 banners/flow*.txt and remove the banner step from each
  Plan skill (plan-start renumbered: gate=第1步, 放行/拦截=第2步 A/B).
- Drop now-unused Bash(cat *) from scope-lock/db-design-gen/downstream-gen/
  plan-start allowed-tools.
- downstream-gen: replace `cp` (not Windows-safe) with Read+Write, drop Bash(cp *).
- project-init: fix stale dispatcher name session-start -> plan-start.
- README: remove the Banners 清单 section.