朱子纯 / erp-workflow-plugin

  • workflow: 行为验收迁回阶段级(v3) + 样式层断言 + 前端测试目录隔离 ...
    ac491fe7 
    行为门 v3（docs/design/2026-06-05-frontend-behavior-stage-gate.md）：
- 行为验收从 per-FE review approve 子门迁回阶段末尾一次（phase Behavior，
  featureLoop 后、testGate 前），保留 fix 循环（BEHAVIOR_STAGE_MAX=3 轮，
  fix 后全量前端单测复验再重跑门）
- req-done/<FE> 语义降为「仅静态 review 过」；行为绿改由 reportPrompt 校验
  阶段级证据（module-reports/frontend-phase-behavior-r*-a*.md 最后一份非 RED）
- build-failed 取消「兄弟未实现」短路（阶段末尾全 FE 已实现）；断言作用域 =
  全部 FE spec「行为验收作用域」小节并集，缺小节记 scope-missing 阻断 green
- 新增样式层 styleIssues（颜色 token 比对 + layout sanity 共 6 kind），
  降维并入 behaviorHard 与交互硬问题同口径 fix；环境仲裁透传 riders 计数

前端测试目录隔离（对齐后端 src/main↔src/test 物理分离）：
- 锁定约定：单测 frontend/tests/** 镜像 src/（smoke 归 tests/__smoke__/ 且
  以 .test.* 结尾），e2e 在 frontend/e2e/，frontend/src/ 禁任何测试产物；
  vitest include 统一限定 tests/**/*.test.*
- 五层防线：docs-04 模板 §2.1 锁定约定 / planPrompt+tddPrompt 硬护栏 /
  fe-skeleton 单测基线 / code-reviewer 新增第 8 维「测试文件隔离」
- legacy 守卫：frontend/src/ 内已存在 colocated 测试时绝不收窄 include
  （防旧单测静默停跑），骨架幂等检测同步豁免，留人工迁移

经两轮多代理对抗审计（34 agents），确认项均已修复。
    zichun authored
     
    Browse Code »
  • workflow: trim dev-only overengineering
    8a8e65a9
    zichun authored
     
    Browse File »
  • coding.mjs: harden per-FE behavior gate per multi-agent review (build-failed gua… ...
    778861b9 
    …rd, coverage reconciliation, testdb halt)

Post-implementation multi-agent review (6 dims + per-finding adversarial verify) found the control-flow sound and the goal mostly-achieved; this lands the three deterministic, low-risk fixes among the confirmed findings.

- build-failed short-circuit (must-fix): behaviorSubGate now validates the LLM's classification before green-by-skip — requires non-empty rootCausePath AND no interaction/sentinel hard issues riding along; a "dirty" build-failed goes through adjudicate(allowContinue:false) retry/halt instead of silently approving. The skeleton (lazy router + FeStub) makes legit sibling-unimpl build breaks rare, so a build-failed is more likely a real in-FE shared-code regression — the boundary comment §107-108 claimed load-bearing but had zero JS enforcement.

- coverage reconciliation backstop (§3.6): empty-coverage only guarded ==0; now 0<routesReached<routesPlanned with the shortfall unexplained by route-level coverageGaps -> adjudicate(allowContinue:false). Closes the partial-coverage false-green. Counts route-level reasons only; over-counting can only suppress the gate, never false-halt.

- test-DB guard direct-halt now implemented: TESTDB_GUARD_MARK in envError.detail + behaviorTestDbGuardTripped -> immediate HALT on the first result, honoring step2's "no retry, no adjudication" promise (previously prompt-only; a guard trip wrongly entered the generic stack-not-ready retry path, ~5 redundant setup-test-db.mjs runs).

Left as accepted design trade-offs (documented in design §12): self-attested whitelist/route scope, soft-by-source non-data text, disabled-control should-work recovery limited to submit buttons.

Verified: SYNTAX_OK (wrapped check), 87/87 lib tests pass, no time/random builtins. v2 design doc updated (§3/5/6.2/6.3 + new §12).
    zichun authored
     
    Browse Code »
  • coding.mjs: move frontend behavior verification INTO per-FE reviewWithFixLoop (fixable dimension) ...
    0588d0dc 
    Replaces the phase-level read-only behavior-gate with a per-FE acceptance dimension: each FE is approved only when the code-reviewer approves AND runtime behavior verification is green. Behavior defects (dead control / sentinel text mismatch) become fixable must-fix that drive verify->fix->re-verify, not halts.

- reviewWithFixLoop (frontend only, via if(fe)): at the approve gate, behaviorSubGate boots this FE's full stack + seeds sentinels, enumerates this FE's routes, two-tier asserts. Hard issues with a locator -> fixPrompt -> functional reverify -> next behaviorRound; soft text (i18n/literal/semantic) -> adjudicate(continue); behaviorRound bounded by BEHAVIOR_FE_MAX=3, env race by BEHAVIOR_ATTEMPT_MAX=2. Backend featureLoop branch unchanged.

- New runFrontendSkeleton stage (before featureLoop(frontend)): App shell + full lazy router + FeStub placeholders + shared nav, so the app is buildable at every mid-phase point; tdd swaps FeStub->real component per FE. Idempotent via fe-skeleton-done tag.

- BEHAVIOR_GATE_SCHEMA gains build-failed envError kind (sibling-FE-unimpl short-circuit, not a bug) + locator-not-resolvable coverage reason; deriveSpec emits a per-FE route-scope section, reviewer validates it.

- Removed phase-level runBehaviorGate + 'Behavior' phase; kept phase-level testGate (regression). REVIEW_HARD_ROUNDS 8->10.

- Safety: test-DB naming guard pushed into scripts-setup-test-db.mjs template (fail-closed unless name contains test/_dev/_local or ALLOW_NONTEST_DROP=1) + 3 tests.

- agentType stays erp-workflow:code-reviewer. v1 design doc marked SUPERSEDED; v2 design at docs/design/2026-06-02-frontend-behavior-in-review-loop.md.

Verified: wrapped syntax check SYNTAX_OK, 87/87 lib tests pass, no orphan refs, no time/random builtins, top-level return intact. Not yet run end-to-end against a real ERP project.
    zichun authored
     
    Browse File »