test(mod): module delete integration coverage REQ-MOD-003

zichun
1 parent bf2370ba
Showing 2 changed files with 108 additions and 0 deletions
backend/src/main/java/com/xly/erp/module/mod/controller/ModuleController.java
backend/src/test/java/com/xly/erp/module/mod/controller/ModuleControllerIT.java
@@ -5,6 +5,7 @@ import com.xly.erp.module.mod.dto.CreateModuleDTO;
 import com.xly.erp.module.mod.dto.UpdateModuleDTO;
 import com.xly.erp.module.mod.service.ModuleService;
 import jakarta.validation.Valid;
+import org.springframework.web.bind.annotation.DeleteMapping;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.PutMapping;
@@ -36,4 +37,10 @@ public class ModuleController {
         Integer updated = moduleService.update(id, dto);
         return Result.ok(Map.of("iIncrement", updated));
     }
+
+    @DeleteMapping("/modules/{id}")
+    public Result<Void> delete(@PathVariable Integer id) {
+        moduleService.delete(id);
+        return Result.ok();
+    }
 }
@@ -287,6 +287,107 @@ class ModuleControllerIT {
         assertThat(objectMapper.readTree(resp.getBody()).get("code").asInt()).isEqualTo(20001);
     }
+    @Test
+    void deleteValidId_with_jwt_returns200_andSoftDeletes() throws Exception {
+        Integer id = insertOriginal("sp_test_del_ok", "原", "ORIG_USER");
+        String token = testJwtHelper.signFor("ADMIN001");
+        HttpHeaders headers = jsonHeaders();
+        headers.set("Authorization", "Bearer " + token);
+
+        ResponseEntity<String> resp = rest.exchange(
+                idUrl(id), HttpMethod.DELETE, new HttpEntity<>(headers), String.class);
+
+        assertThat(resp.getStatusCode().value()).isEqualTo(200);
+        JsonNode jb = objectMapper.readTree(resp.getBody());
+        assertThat(jb.get("code").asInt()).isZero();
+        assertThat(jb.get("data").isNull()).isTrue();
+
+        Map<String, Object> row = jdbcTemplate.queryForMap(
+                "SELECT bDeleted, sDeletedBy, tDeletedDate, sProcedureName, sCreatedBy FROM tModule WHERE iIncrement = ?", id);
+        assertThat(row.get("bDeleted")).isEqualTo(true);
+        assertThat(row.get("sDeletedBy")).isEqualTo("ADMIN001");
+        assertThat(row.get("tDeletedDate")).isNotNull();
+        assertThat(row.get("sProcedureName")).isEqualTo("sp_test_del_ok");
+        assertThat(row.get("sCreatedBy")).isEqualTo("ORIG_USER");
+    }
+
+    @Test
+    void deleteNonExistentId_returns40400() throws Exception {
+        String token = testJwtHelper.signFor("ADMIN001");
+        HttpHeaders headers = jsonHeaders();
+        headers.set("Authorization", "Bearer " + token);
+
+        ResponseEntity<String> resp = rest.exchange(
+                idUrl(99999996), HttpMethod.DELETE, new HttpEntity<>(headers), String.class);
+
+        assertThat(objectMapper.readTree(resp.getBody()).get("code").asInt()).isEqualTo(40400);
+    }
+
+    @Test
+    void deleteAlreadyDeletedId_returns40400() throws Exception {
+        Integer id = insertOriginal("sp_test_del_already", "已删", "ORIG");
+        jdbcTemplate.update("UPDATE tModule SET bDeleted = 1 WHERE iIncrement = ?", id);
+        String token = testJwtHelper.signFor("ADMIN001");
+        HttpHeaders headers = jsonHeaders();
+        headers.set("Authorization", "Bearer " + token);
+
+        ResponseEntity<String> resp = rest.exchange(
+                idUrl(id), HttpMethod.DELETE, new HttpEntity<>(headers), String.class);
+
+        assertThat(objectMapper.readTree(resp.getBody()).get("code").asInt()).isEqualTo(40400);
+    }
+
+    @Test
+    void deleteWithActiveChildren_returns40901() throws Exception {
+        Integer rootId = insertOriginal("sp_test_del_root", "根", "ORIG");
+        jdbcTemplate.update(
+                "INSERT INTO tModule (sBrandsId, sSubsidiaryId, tCreateDate, sDisplayType, sProcedureName, "
+                        + "sModuleType, sManageDeptEn, bShowPermission, sModuleNameZh, iParentId, iSortOrder, sCreatedBy, bDeleted) "
+                        + "VALUES ('XLY','XLY', NOW(), '手机端', 'sp_test_del_child', '业务模块', 'IT', 0, '子', ?, 0, 'ORIG', 0)",
+                rootId);
+        String token = testJwtHelper.signFor("ADMIN001");
+        HttpHeaders headers = jsonHeaders();
+        headers.set("Authorization", "Bearer " + token);
+
+        ResponseEntity<String> resp = rest.exchange(
+                idUrl(rootId), HttpMethod.DELETE, new HttpEntity<>(headers), String.class);
+
+        assertThat(objectMapper.readTree(resp.getBody()).get("code").asInt()).isEqualTo(40901);
+        Boolean stillAlive = jdbcTemplate.queryForObject(
+                "SELECT bDeleted FROM tModule WHERE iIncrement = ?", Boolean.class, rootId);
+        assertThat(stillAlive).isFalse();
+    }
+
+    @Test
+    void deleteWithoutJwt_permitAllStub_returns200_andDeletedByIsSTUB() throws Exception {
+        Integer id = insertOriginal("sp_test_del_nojwt", "原", "ORIG");
+        HttpHeaders headers = jsonHeaders();
+
+        ResponseEntity<String> resp = rest.exchange(
+                idUrl(id), HttpMethod.DELETE, new HttpEntity<>(headers), String.class);
+
+        assertThat(objectMapper.readTree(resp.getBody()).get("code").asInt()).isZero();
+        Map<String, Object> row = jdbcTemplate.queryForMap(
+                "SELECT bDeleted, sDeletedBy FROM tModule WHERE iIncrement = ?", id);
+        assertThat(row.get("bDeleted")).isEqualTo(true);
+        assertThat(row.get("sDeletedBy")).isEqualTo("STUB_ADMIN");
+    }
+
+    @Test
+    void deleteTamperedJwt_returns20001() throws Exception {
+        Integer id = insertOriginal("sp_test_del_tamper", "原", "ORIG");
+        HttpHeaders headers = jsonHeaders();
+        headers.set("Authorization", "Bearer not.a.real.jwt");
+
+        ResponseEntity<String> resp = rest.exchange(
+                idUrl(id), HttpMethod.DELETE, new HttpEntity<>(headers), String.class);
+
+        assertThat(objectMapper.readTree(resp.getBody()).get("code").asInt()).isEqualTo(20001);
+        Boolean stillAlive = jdbcTemplate.queryForObject(
+                "SELECT bDeleted FROM tModule WHERE iIncrement = ?", Boolean.class, id);
+        assertThat(stillAlive).isFalse();
+    }
+
     private Integer insertOriginal(String procedureName, String nameZh, String createdBy) {
         jdbcTemplate.update(
                 "INSERT INTO tModule (sBrandsId, sSubsidiaryId, tCreateDate, sDisplayType, sProcedureName, "