fix(usr): 修复 review round 1 must-fix REQ-USR-003

zichun
1 parent 85eeceb5
Showing 5 changed files with 8 additions and 4 deletions
backend/src/main/java/com/example/erp/module/usr/controller/UserController.java
backend/src/main/java/com/example/erp/module/usr/service/impl/UserServiceImpl.java
backend/src/main/resources/mapper/UsrUserMapper.xml
docs/05-API接口契约.md
frontend/src/pages/usr/UserListPage.tsx
@@ -31,6 +31,7 @@ public class UserController {
         return Result.ok(userService.createUser(req, principal));
     }
  
+    // REQ-USR-003: 查询用户
     @GetMapping("/users")
     public Result<PageVO<UserListItemVO>> getUsers(
             @RequestParam(defaultValue = "username") String queryField,
@@ -121,6 +121,7 @@ public class UserServiceImpl implements UserService {
         }).collect(Collectors.toList());
     }
  
+    // REQ-USR-003: 查询用户
     @Override
     @Transactional(readOnly = true)
     public PageVO<UserListItemVO> getUserList(UserListQueryDTO query, String brandId) {
@@ -3,6 +3,7 @@
         "http://mybatis.org/dtd/mybatis-3-mapper.dtd">
 <mapper namespace="com.example.erp.module.usr.mapper.UsrUserMapper">
  
+    <!-- REQ-USR-003: 查询用户 -->
     <select id="selectUserList" resultType="com.example.erp.module.usr.vo.UserListItemVO">
         SELECT u.sId, u.sUsername, u.sUserCode, u.sUserType, u.sLanguage,
                u.bIsDisabled, u.tLastLoginDate, u.sCreatorUsername, u.tCreateDate,
@@ -24,7 +25,7 @@
                 <when test="queryField == 'staffName'">
                     <choose>
                         <when test="matchType == 'contains'">AND s.sStaffName LIKE CONCAT('%', #{queryValue}, '%')</when>
-                        <when test="matchType == 'notContains'">AND s.sStaffName NOT LIKE CONCAT('%', #{queryValue}, '%')</when>
+                        <when test="matchType == 'notContains'">AND (s.sStaffName IS NULL OR s.sStaffName NOT LIKE CONCAT('%', #{queryValue}, '%'))</when>
                         <otherwise>AND s.sStaffName = #{queryValue}</otherwise>
                     </choose>
                 </when>
@@ -38,7 +39,7 @@
                 <when test="queryField == 'department'">
                     <choose>
                         <when test="matchType == 'contains'">AND s.sDepartment LIKE CONCAT('%', #{queryValue}, '%')</when>
-                        <when test="matchType == 'notContains'">AND s.sDepartment NOT LIKE CONCAT('%', #{queryValue}, '%')</when>
+                        <when test="matchType == 'notContains'">AND (s.sDepartment IS NULL OR s.sDepartment NOT LIKE CONCAT('%', #{queryValue}, '%'))</when>
                         <otherwise>AND s.sDepartment = #{queryValue}</otherwise>
                     </choose>
                 </when>
@@ -73,8 +73,8 @@ BasePath: `/api`
 - **Path**: `/api/usr/users`
 - **Auth**: Bearer Token
 - **Permission**: `usr:query`
-- **请求**: Query 参数：`field=用户名|员工名|用户号|部门|用户类型|作废|登录日期|制单人`、`matchMode=包含|不包含|等于`、`value=string`、`pageNum=int`、`pageSize=int`
-- **响应**: `{ list: [{ "userId", "username", "staffName", "userCode", "department", "userType", "language", "isDisabled", "lastLoginDate", "creatorUsername", "createDate" }], total, pageNum, pageSize }` — 密码字段不返回
+- **请求**: Query 参数：`queryField=username|staffName|userCode|department|userType|disabled|lastLoginDate|creator`（默认 username）、`matchType=contains|notContains|equals`（默认 contains）、`queryValue=string`、`page=int`（默认 1）、`pageSize=int`（默认 20，最大 100）
+- **响应**: `{ list: [{ "sId", "sUsername", "sUserCode", "sUserType", "sLanguage", "bIsDisabled", "tLastLoginDate", "sCreatorUsername", "tCreateDate", "sStaffName", "sDepartment" }], total, page, pageSize }` — sPasswordHash / iLoginFailCount / tLockUntil 不返回
  
 #### 错误码
 - `40001` — 参数校验失败
@@ -36,6 +36,7 @@ const columns: ColumnsType&lt;UserListItemVO&gt; = [
   { title: '制单日期', dataIndex: 'tCreateDate' },
 ]
  
+// REQ-USR-003: 查询用户
 export default function UserListPage() {
   const [drawerOpen, setDrawerOpen] = useState(false)
   const [data, setData] = useState<PageVO<UserListItemVO> | null>(null)